Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Offer to attempt again with conflicting deps unlocked when version resolution fails #3622

Open
lpil opened this issue Sep 15, 2024 · 6 comments · May be fixed by #3970
Open

Offer to attempt again with conflicting deps unlocked when version resolution fails #3622

lpil opened this issue Sep 15, 2024 · 6 comments · May be fixed by #3970
Labels
help wanted Contributions encouraged priority:medium

Comments

@lpil
Copy link
Member

lpil commented Sep 15, 2024 •
edited
Loading

If you add a new dep it can fail due to conflicts with already locked versions of other deps.

I don't know how effective this might be, but I think we could do this:

  • When we have a version conflict
  • and some of the packages in the conflict chain are locked
  • offer to unlock those packages and try again

If we are on CI (we can look for CI related environment variables) do not offer this functionality.
@lpil lpil added help wanted Contributions encouraged priority:medium labels Sep 15, 2024
@raquentin raquentin linked a pull request Dec 8, 2024 that will close this issue
Draft
4 tasks
@raquentin
Copy link
Contributor

What were you thinking for CI-related env vars

@lpil
Copy link
Member Author

lpil commented Dec 9, 2024

We can research what the popular CI platforms set.

@raquentin
Copy link
Contributor

One more thing, sry for spam, does "offer to unlock" packages involve some sort of cli action where user says like yes/no to update their gleam.toml, if so is there an example of another command setting up a series of cli fns in this way? Ty

@lpil
Copy link
Member Author

lpil commented Dec 9, 2024

I think we'd print the error, and then something like

Some of these dependencies are locked to specific versions. It may
be possible to find a solution if they are unlocked, would you like
to unlock and try again? [y/n]

@raquentin
Copy link
Contributor

Can you explain a bit more a case where this flow is triggered? I originally misunderstood "locked" a bit. Would this occur during gleam add <pkg> when <pkg> needs a minimum stdlib version of 0.3 or something but manifest.toml has it capped at 0.2?

@lpil
Copy link
Member Author

lpil commented Dec 10, 2024

Any time when resolution fails and the packages responsible for the failure are in the manifest, meaning they are locked

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Contributions encouraged priority:medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

suggest unlocking locked pkgs that cause dep resolution failures raquentin/gleam
2 participants
@lpil @raquentin