Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml file extension: .yml or .yaml #700

Open
dabcoder opened this issue Oct 9, 2024 · 4 comments
Open

Yaml file extension: .yml or .yaml #700

dabcoder opened this issue Oct 9, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@dabcoder
Copy link

dabcoder commented Oct 9, 2024

Prerequisites:

  • Is the functionality available in the GitHub UI?

No / N/A

  • Is the functionality available through the GitHub API?

No / N/A

New Feature

The README states that files with the .yaml file extension will be ignored. Yet both .yaml and .yml are valid. Therefore, I've got a couple of suggestions:

a. Either return an error when the .yaml file extension is in use, in order to notify users they should switch to .yml.
b. Support both file extensions. Could it be around here?

@dabcoder dabcoder added the enhancement New feature or request label Oct 9, 2024
@dabcoder
Copy link
Author

Any feedback on the above?

@Technobeats
Copy link

Technobeats commented Nov 8, 2024

+1 Lost some time today by accidentally creating a file with .yaml.
Strange part is .yaml is being picked up and visible in the debug-logging but not applied.
After changing it to .yml the config was applied

@dabcoder
Copy link
Author

cc @decyjphr for visibility

@paddyroddy
Copy link

I got it working with .yaml here https://github.com/UCL-MIRSG/.github/tree/main/safe-settings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants