Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: conditional rendering from TemplateResult -> Text -> TemplateResult #23

Open
luwes opened this issue Apr 1, 2022 · 0 comments
Open

Comments

@luwes
Copy link

luwes commented Apr 1, 2022

Was wondering if there are any limitations with rendering?
We came across a bug where a conditional like below does not work after toggling the title on and off and on again.

html`${props.dialog?.title ? html`<h3>${props.dialog.title}</h3>` : ''}`

Surprisingly this does work

html`${props.dialog?.title ? html`<h3>${props.dialog.title}</h3>` : html``}`

Related to muxinc/elements#165


For example go to elements-demo-vanilla-k15aiiyns-mux.vercel.app/mux-player.html

Open the error dialog with the button below the player, close with the button next to it, open again
=> the dialog title is not showing while it should be showing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant