Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Enhance text placement in relation to edges #12

Open
5 tasks
chrisreddington opened this issue Dec 1, 2024 · 0 comments · May be fixed by #46
Open
5 tasks

[Feature]: Enhance text placement in relation to edges #12

chrisreddington opened this issue Dec 1, 2024 · 0 comments · May be fixed by #46
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@chrisreddington
Copy link
Collaborator

chrisreddington commented Dec 1, 2024

Description

Currently, the text rendering in gh-skyline places the text a little arbitrarily within the rendered elements. We want to improve this by placing the username and the year at a certain distance from their respective (left and right) edges

Requirements

  • Modify the text rendering logic to place the username a specified distance from the left edge.
  • Place the year the same specified distance from the right edge.
  • Ensure the distance is configurable through the textRenderConfig struct.
  • Update any relevant documentation to reflect these changes.
  • Write unit tests to verify the new text placement

Definition of Done

  • The username is placed a specified distance from the left edge.
  • The year is placed the same specified distance from the right edge.
  • The distance is configurable via textRenderConfig.
  • Relevant documentation is updated.
  • Unit tests are updated/written and passing.

Additional Notes

  • Follow standard Go conventions and best practices.
  • Use clear, descriptive variable and function names.
  • Add comments to explain complex logic or non-obvious implementations.
  • Include GoDoc comments for all changes.

This issue is a great opportunity for new contributors to get familiar with the codebase and make a meaningful improvement. If you have any questions, feel free to ask!

@chrisreddington chrisreddington added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed labels Dec 1, 2024
@github-project-automation github-project-automation bot moved this to Needs Review in gh-skyline Dec 1, 2024
@chrisreddington chrisreddington moved this from Needs Review to Ready to Start in gh-skyline Dec 1, 2024
@chrisreddington chrisreddington changed the title Enhance text placement in relation to edges [Feature]: Enhance text placement in relation to edges Dec 2, 2024
@mkhuzaima mkhuzaima linked a pull request Dec 14, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Ready to Start
Development

Successfully merging a pull request may close this issue.

1 participant