You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our Secret Scanning solution has expanded to search for secrets in other GitHub repository contents than only git history. We need to include the new location types when migration secret scanning alerts between repositories.
The /repos/{owner}/{repo}/secret-scanning/alerts/{alert_number}/locationsREST API endpoint response gives us good overview of locations that we need to consider and match on. Current location types:
Furthermore, when migrating Secret Scanning alerts, currently the tool only migrates the state but not the resolution_comment. Given this information might include evidence (or pointers to) for auditing purposes, we should be keeping it when migrating as well.
Todo
Update GitHubSecretScanningAlert model with fields related to new location types and comments
Update GitHubApi service to populate all new fields for new location types and comment
Update SecretScanningAlertService logic to match on new types (current matching criteria)
Review/adapt/add tests
Update RELEASENOTES.md
Dependencies
n/a
The text was updated successfully, but these errors were encountered:
Our Secret Scanning solution has expanded to search for secrets in other GitHub repository contents than only git history. We need to include the new location types when migration secret scanning alerts between repositories.
The
/repos/{owner}/{repo}/secret-scanning/alerts/{alert_number}/locations
REST API endpoint response gives us good overview of locations that we need to consider and match on. Current location types:Furthermore, when migrating Secret Scanning alerts, currently the tool only migrates the state but not the
resolution_comment
. Given this information might include evidence (or pointers to) for auditing purposes, we should be keeping it when migrating as well.Todo
Dependencies
n/a
The text was updated successfully, but these errors were encountered: