feat(uptime): Use UptimeSubscriptionRegion to direct config updates to the appropriate region topic
#82441
+184
−86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to the appropriate region topic This uses `UptimeSubscriptionRegion` to determine which regions a subscription should be run in, and sends config updates to each of those regions. Changes the config producer to use `UPTIME_REGIONS` to route messages to the appropriate topic, instead of being hardcoded. Also includes hacks to use the default region when no regions exist for a subscription. This is temporary until we start writing `UptimeSubscriptionRegion` rows. We should wait until getsentry/ops#13422 is merged before going ahead, so that regions are appropriately configured in production.
github-actions
bot
added
the
Scope: Backend
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## master #82441 +/- ##
==========================================
- Coverage 80.44% 80.43% -0.01%
==========================================
Files 7307 7307
Lines 322174 322186 +12
Branches 21014 21014
==========================================
- Hits 259159 259145 -14
- Misses 62609 62635 +26
Partials 406 406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
UptimeSubscriptionRegionto determine which regions a subscription should be run in, and sends config updates to each of those regions.Changes the config producer to use
UPTIME_REGIONSto route messages to the appropriate topic, instead of being hardcoded.Also includes hacks to use the default region when no regions exist for a subscription. This is temporary until we start writing
UptimeSubscriptionRegionrows.We should wait until https://github.com/getsentry/ops/pull/13422 is merged before going ahead, so that regions are appropriately configured in production.