Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Visualize field #81506

Closed
4 tasks done
narsaynorath opened this issue Dec 2, 2024 · 2 comments
Closed
4 tasks done

Add Visualize field #81506

narsaynorath opened this issue Dec 2, 2024 · 2 comments

Comments

@narsaynorath
Copy link
Member

narsaynorath commented Dec 2, 2024

  • Says "Add Series" if timeseries chart, "Add Columns" for table
  • Follow up about big number, possibly another component

TODO:

@getsantry
Copy link
Contributor

getsantry bot commented Dec 6, 2024

Routing to @getsentry/product-owners-dashboards for triage ⏲️

narsaynorath added a commit that referenced this issue Dec 9, 2024
Adds a foundation for the visualize field. This field is pretty complex
so I've had to break it down into smaller tasks as I discovered them.
For this PR it's focused on charts and aggregates, so tables aren't
guaranteed to work and it'll only allow you to select functions right
now.

Functionality involved (assuming timeseries chart selected):
- the argument/column selector and the aggregate selectors should show
the right values for the dataset
- Note: Going between datasets doesn't automatically flush the existing
values, so just look at the values that get presented in the dropdowns
and verify they're the same as the old widget builder
- I noticed there's an extra `span.duration` in the release dataset,
I'll follow up about it, but ignore that for now
- You can add a series
- You can delete a series iff there's more than 1 series selected
- an "Add Equation" button is shown but it doesn't do anything right now
- Custom measurements should appear in the transactions dataset

Sets the foundation for #81506
mifu67 pushed a commit that referenced this issue Dec 10, 2024
Adds a foundation for the visualize field. This field is pretty complex
so I've had to break it down into smaller tasks as I discovered them.
For this PR it's focused on charts and aggregates, so tables aren't
guaranteed to work and it'll only allow you to select functions right
now.

Functionality involved (assuming timeseries chart selected):
- the argument/column selector and the aggregate selectors should show
the right values for the dataset
- Note: Going between datasets doesn't automatically flush the existing
values, so just look at the values that get presented in the dropdowns
and verify they're the same as the old widget builder
- I noticed there's an extra `span.duration` in the release dataset,
I'll follow up about it, but ignore that for now
- You can add a series
- You can delete a series iff there's more than 1 series selected
- an "Add Equation" button is shown but it doesn't do anything right now
- Custom measurements should appear in the transactions dataset

Sets the foundation for #81506
@narsaynorath
Copy link
Member Author

Closing this as I've split off the remaining tasks into separate smaller tickets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

3 participants