Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimated time to merge a PR is 13 minutes; is that the fastest we can do? #738

Open
masih opened this issue Nov 6, 2024 · 4 comments
Open
Labels
enhancement New feature or request nice to have

Comments

@masih
Copy link
Member

masih commented Nov 6, 2024

Investigate how much we can make the merging process faster without affecting the benefits. 13m for a PR merge is too long.

@github-project-automation github-project-automation bot moved this to Todo in F3 Nov 6, 2024
@masih masih added enhancement New feature or request nice to have labels Nov 6, 2024
@Stebalien
Copy link
Member

I'm trying new runners:

  1. 2xlarge takes 10m (down from 12m).
  2. 4xlarge takes 7m.

I'm not really sure if that's worth it, but we can try it for a while. I'm starting with 4xlarge because 2xlarge definitely isn't worth it. And the machines are spun up on demand so they shouldn't be too expensive...

@masih
Copy link
Member Author

masih commented Nov 21, 2024

Yes too expensive for the time gain. Thank you for trying those out

@Stebalien
Copy link
Member

I've dropped us back to the defaults for now. TBH, we likely just need to speed up the tests a bit.

@Kubuxu
Copy link
Contributor

Kubuxu commented Nov 22, 2024

We could narrow down the test set in the merge queue. Most of our repos run zero tests in that phase.
Getting our tests would be nice as well but the above is lowest cost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nice to have
Projects
Status: Todo
Development

No branches or pull requests

3 participants