Update sector health rate to account for all sectors (not just active sectors)

[BigLep]

I believe the "Sector Health Rate" metric is currently

$$\frac{\text{Number of Active Sectors - Number of Faulted Sectors}}{\text{Number of Active Sectors}}$$

Where Active Sectors is sectors that are truly in the "Active State". I think actually what we want is:

$$\frac{\text{Number of All Sectors - Number of Faulted Sectors}}{\text{Number of All Sectors}}$$

I think that will prevent the dips we see in the "Active Sectors" graph:

https://filecoin-project.github.io/filecoin-storage-providers-market/provider/f01083914#durability

Basically I think we want to compare faulted sectors with the total number of sectors that an SP has, regardless of what state the sectors are in (looking at the states in https://lotus.filecoin.io/reference/lotus/state/#stateminerpartitions ).

[davidgasquez]

Heya @BigLep!

The current definition is:

$$\frac{\text{Number of Active Sectors}}{\text{Number of Active Sectors + Number of Faulted Sectors}}$$

We are deriving active sectors from the SP raw power. With this definition, we're counting Active + Faulted sectors in each day calculations.

We have daily sector events for providers we could play with and add it to create an AllSectors but I wonder if we want to include things like snapped / terminated.

A question that just popped up is: do recovered / recovering sectors count as Active? It not, we should change the formula to:

$$\frac{\text{Number of Active Sectors + Number of Recovering Sectors}}{\text{Number of Active Sectors + Number of Faulted Sectors + Number of Recovering}}$$