Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for recursive blame #2194

Open
knuesel opened this issue Apr 17, 2024 · 1 comment · May be fixed by #2285
Open

Support for recursive blame #2194

knuesel opened this issue Apr 17, 2024 · 1 comment · May be fixed by #2285
Labels
feature-request

Comments

@knuesel
Copy link

knuesel commented Apr 17, 2024

For example in tig (and similarly in magit) you can blame recursively like this: Start by blaming some file, go to some line. Then press , to show the blame view of the same region of the same file but at the parent commit. This can be repeated to travel further back in time, always showing the same region of file. Press < to go the other way (forward in time).

This is very handy when trying to understand the history of a particular piece of code. It would be great to have it supported in gitui!
@ilyagr
Copy link

ilyagr commented May 7, 2024 •
edited
Loading

A more discoverable shortcut for this might be pressing Shift-B again (since we're running Blame again on a different commit). Perhaps left arrow can go back (though perhaps we can think of something better than that).

As an aside, Tig works well for this, but I found its shortcuts hard to discover or remember. I did write them up in jonas/tig#1315 (comment).

kanielrkirby pushed a commit to kanielrkirby/gitui that referenced this issue Jul 1, 2024
Support recursive blame (fixes extrawurst#2194)
8998aec 
- Replaces `BlameFilePopup.blame: Option<BlameProcess>` with `BlameFilePopup.blame_stack: Vec<BlameProcess>`.
- Adds keybinding for going back from a blame (`b`).
- Makes keybinding for `blame` (`Shift+B`) work in the `popups/blame_file.rs` view, where it will take the commit and open a blame from that.
@kanielrkirby kanielrkirby linked a pull request Jul 1, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for recursive blame kanielrkirby/gitui
2 participants
@knuesel @ilyagr