Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell-escape $in, $in_newline, $out, and $out_newline #117

Open
Colecf opened this issue May 7, 2024 · 0 comments
Open

Shell-escape $in, $in_newline, $out, and $out_newline #117

Colecf opened this issue May 7, 2024 · 0 comments

Comments

@Colecf
Copy link
Contributor

Colecf commented May 7, 2024

When these special variables are evaluated, they need to be shell-escaped.

There also needs to be scenarios where they're not escaped, such as getting the paths to certain files like the depfile, rspfile, and dyndep file. This is presumably so that you can do rspfile = $out.rsp, and since ninja will directly open rspfile instead of going through the shell, it needs to not be escaped.

This change would merge conflict with my #112, so I'll probably just do the fix in the android fork and not upstream it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant