Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Recording saved" note may not be correct #1116

Open
lkiesow opened this issue Sep 21, 2023 · 1 comment
Open

"Recording saved" note may not be correct #1116

lkiesow opened this issue Sep 21, 2023 · 1 comment
Labels
type:bug Something isn't working type:visual-clarity A part of the UI is not clear/visually readable

Comments

@lkiesow
Copy link
Contributor

lkiesow commented Sep 21, 2023

  1. Make sure your browser is set to opening a download dialog
  2. Record a video
  3. Hit d to download
    • download dialog opens
  4. Cancel the dialog e.g. by hitting Esc
    • The interface tells you that you successfully downloaded the video

Screenshot from 2023-09-22 00-42-39

@lkiesow lkiesow added type:bug Something isn't working type:visual-clarity A part of the UI is not clear/visually readable labels Sep 21, 2023
@LukasKalbertodt
Copy link
Member

Yep, that has been an issue for a long time :/
We simply can't know for sure whether the file was saved. I certainly don't know of any way. In the end, the user can always remove the file after the download, so we can't know for sure.

What we need this "download detection" for mostly is to decide whether we let the user simply close the tab. We allow that (without warning) if the video has been up- or downloaded. We could of course just remove the "Recording saved" UI you refer to here, but still use the same logic to decide whether the user can just close the tab.

But yeah, either way, not ideal. I don't know a good solution.

@LukasKalbertodt LukasKalbertodt changed the title Recording saved may not be correct "Recording saved" note may not be correct Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Something isn't working type:visual-clarity A part of the UI is not clear/visually readable
Projects
None yet
Development

No branches or pull requests

2 participants