Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should docopt::Options be an std::unordered_map? #154

Open
mansoor2016 opened this issue Apr 13, 2022 · 2 comments
Open

Should docopt::Options be an std::unordered_map? #154

mansoor2016 opened this issue Apr 13, 2022 · 2 comments

Comments

@mansoor2016
Copy link

Is the ordered nature of the options used?

@mibli
Copy link

mibli commented May 16, 2022

Definietevely in run_testcase.cpp, but it could be changed, since performance of tests doesn't matter.

@jaredgrubb
Copy link
Member

In retrospect maybe it should have been unordered_map but map was just chosen as default. I don't really see much benefit or issue either way -- I don't expect that most uses are going to have more than 10s of options, certainly not 10000s!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants