Build Jsonrpc-server for darwin #6204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Septias
force-pushed
the
sk/json_rpc_darwin
branch
from
e1c48e3 to
9754299
Compare
Septias
commented
Nov 13, 2024
| @@ -243,16 +255,6 @@ | |||
| ]; | |||
| auditable = false; # Avoid cargo-auditable failures. | |||
| doCheck = false; # Disable test as it requires network access. | |||
|
|
|||
| CARGO_BUILD_TARGET = rustTarget; | |||
There was a problem hiding this comment.
Had to remove this so the build succeeds, what were the intentions and is it really needed? @link2xt
There was a problem hiding this comment.
This enables cross-compilation, otherwise building on arm builds for arm and building on x86_64 builds for x86_64. rustTarget should be used at least somewhere, this change seems to remove all usage of it.
Better manually check that the resulting build is for the correct arch once it finishes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds x84_64-darwin and aarch-darwin as packages to flake.nix
This depends on #6203, we should merge it first so I can rebase and we get an easy diff for this one.
close #6095