Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserving of P8SCII Control Codes #89

Open
Liquidream opened this issue Sep 19, 2021 · 3 comments
Open

Preserving of P8SCII Control Codes #89

Liquidream opened this issue Sep 19, 2021 · 3 comments

Comments

@Liquidream
Copy link

(I believe you've yet to look at P8SCII, so this is just an FYI for when you do)

Currently, when picotool/luamin processes source files wish such code as below:

print("\^w\^thello world")

...it results in the backslashes being escaped (breaking the P8SCII Control Codes):

print("\\^w\\^thello world")
@Liquidream
Copy link
Author

Just ran into this one again while updating SCUMM-8.
I guess this more a case of preserving single backslashes ""
Which I guess might be a challenge for your parser? (hope not)

@hsandt
Copy link

hsandt commented May 19, 2022

I also needed to write instructions such as "Press 🅾 (O glyph)" and the 🅾 (O glyph) became "ユか✽ゆヤま◆". After processing Lua content with Python, it was even flattened to "_______" (this is an issue on my side, not sure why as I'm processing UTF-8; but first the issue must be fixed on picotool side, then I can see if I need more work to make the glyph work).

I saw some update of glyphs and updated picotool to latest, but the issue was still there.

@simonwulf
Copy link

I recently encountered the same issue as @hsandt and decided to look into it. I was able to remove the issue by disabling all unescaping of P8SCII escape sequences. I believe this should solve your issue as well, @Liquidream.

I made a PR for the suggested fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants