docs are wrong on parameters?

[nicferrier]

Are the docs wrong on parameters?

for example:

crystal-db/src/db/query_methods.cr

Line 67 in 437f8c3

def query_one(query, *args, &block : ResultSet -> U) : U forall U

I'm using 0.4.1 shard and had to use $x (eg: $1) for params and not ?.

Is this right or am I confused?

[bcardiff]

Hi @nicferrier . Is a duplicate of #30 .
crystal-db does not touch the sql statement, so it depends on each driver.
Adding that note to every example seems wrong, but clearly the question will keep coming 💭

[rurounijones]

Checking in as another person who was confused and lost quite a lot of time on this.

[straight-shoota]

Maybe it would already help to make the individual examples self-contained, so the reader can see that it is for a MySQL database:

MySQL::Database.open(ENV["DATABASE_URL"]) do |db|
  name = db.query_one "select name from contacts where id = ?", 18, &.read(String)
end

Still, a note about different parameter syntax depending on the database system should better be added to every method accepting arguments.