Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some reserved words not highlighting java #91

Open
Usernametaken12 opened this issue Dec 22, 2022 · 3 comments · May be fixed by #96
Open

Some reserved words not highlighting java #91

Usernametaken12 opened this issue Dec 22, 2022 · 3 comments · May be fixed by #96
Labels
good first issue Good for newcomers help wanted Extra attention is needed wontfix This will not be worked on

Comments

@Usernametaken12
Copy link

"null" does not change color in the ide, despite being a reserved literal value in java. For the sake of completeness, "_", another reserved keyword, while not important in any way, does not change color. All other obscure keywords seem to work as intended, though.

@thecodingwizard
Copy link
Member

This seems to be the default behavior of Monaco: https://microsoft.github.io/monaco-editor/monarch.html

I don't know why that is the case. It probably isn't too hard to explicitly mark null as a keyword for Java though (PR's welcome!)

@thecodingwizard thecodingwizard added good first issue Good for newcomers help wanted Extra attention is needed wontfix This will not be worked on labels Mar 4, 2023
@vedant-z
Copy link

Hi @thecodingwizard I would like to solve this one. Just need some hint if possible.

@thecodingwizard
Copy link
Member

@vedant-z thanks! The monaco editor is created here:

export default function MonacoEditor({
I am guessing that would be where you would want to make your changes.

@vedant-z vedant-z linked a pull request Mar 10, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants