Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DRAFT] feat: dynamically import optional built-in components [ALT-1456] #841

Draft
wants to merge 6 commits into
base: development
Choose a base branch
from
Draft

[DRAFT] feat: dynamically import optional built-in components [ALT-1456] #841

wants to merge 6 commits into from

Conversation

primeinteger
Copy link
Contributor

@primeinteger primeinteger commented Nov 20, 2024 •
edited
Loading

Purpose

  • Use dynamic imports to only load the built-in basic components when needed

Impact

  • BREAKING: built-in basic components are only registered if defineComponents() is called
  • BREAKING: when maintainBasicComponentIdsWithoutPrefix() is used, it should be called before defineComponents()

TODO

  • update rollup config for components package to generate optional component bundles
  • fix SDK build errors for dynamic imports
  • fix auto-generated changelogs (repository healthy necessary before merging a breaking change)
  • write a migration guide to help users navigate the breaking changes when upgrading

@primeinteger primeinteger requested review from a team as code owners November 20, 2024 02:29
@vercel Vercel
Copy link

vercel bot commented Nov 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nextjs-marketing-demo-bug-test ✅ Ready (Inspect) Visit Preview Dec 11, 2024 9:27pm
3 Skipped Deployments
Name Status Preview Updated (UTC)
experience-builder-test-app ⬜️ Ignored (Inspect) Dec 11, 2024 9:27pm
studio-nextjs-marketing-demo ⬜️ Ignored (Inspect) Dec 11, 2024 9:27pm
studio-react-vite-template ⬜️ Ignored (Inspect) Dec 11, 2024 9:27pm

@primeinteger
feat: dynamically import optional built-in components [ALT-1425]
6d980bf 
BREAKING CHANGE: User apps must call defineComponents to register built-in basic components now
@primeinteger primeinteger force-pushed the ALT-1425/optional-component-imports branch from 5441053 to 6d980bf Compare November 20, 2024 15:46
@primeinteger primeinteger changed the title feat: dynamically import optional built-in components [ALT-1425] [DRAFT] feat: dynamically import optional built-in components [ALT-1425] Nov 20, 2024
@primeinteger primeinteger marked this pull request as draft November 20, 2024 20:38
@primeinteger
feat(components): update rollup config to generate optional component…
8ff5a53 
… bundles

fix(experience-builder-sdk): revise dynamic imports for optional components
@primeinteger primeinteger changed the title [DRAFT] feat: dynamically import optional built-in components [ALT-1425] [DRAFT] feat: dynamically import optional built-in components [ALT-1456] Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@primeinteger