Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markerplace contract autodiscovery for Circuit download tool #987

Open
veaceslavdoina opened this issue Nov 4, 2024 · 0 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@veaceslavdoina
Copy link
Contributor

veaceslavdoina commented Nov 4, 2024

Is your feature request related to a problem? Please describe.
Simplify cirld usage and Codex storage node upgrade.

Describe the solution you'd like
Circuit downloader (cirdl) should support marketplace contract address autodiscovery, like it is done for Codex now.

Describe alternatives you've considered
Now, we are passing marketplace address manually and it is not so convenient, especially if we would like to automate Codex upgrade.

Additional context
cirdl binary should support the following CLI arguments

  • cirdl --help - show help about how to use the app
  • cirdl --version - show app version, to identify compatible Codex version

We also, should be able to run cirdl by passing just [circuitPath] [rpcEndpoint]

cirdl data/circuits http://rpc.url

and optionally pass a custom marketplace address if we would like to use a different one

cirdl data/circuits http://rpc.url 0x5Bd66fA15Eb0E546cd26808248867a572cFF5706

In that way we can simplify Codex upgrade process and skip marketplace address passing. It would be very usefully, especially for Storage providers, because for now latest contract can be found in the documentation or nim-codex source code.

@veaceslavdoina veaceslavdoina added the enhancement New feature or request label Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants