Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to disable manifest diff. #3271

Open
krismarc opened this issue Oct 29, 2024 · 1 comment
Open

Possibility to disable manifest diff. #3271

krismarc opened this issue Oct 29, 2024 · 1 comment

Comments

@krismarc
Copy link

Hi there,

after migration from v7 to v8, I've noticed introduction of manifest diff. Would be nice to have an option to disable it with an env var or so or at least prevent it's output from being passed to stdout.

diff, warnings, err := cmd.Actor.DiffSpaceManifest(spaceGUID, transformedRawManifest)

diff, warnings, err := cmd.Actor.DiffSpaceManifest(spaceGUID, manifestBytes)

..some conditional skip would need to be present here.

Reasoning behind it. I know envs are not supposed to be used to treat sensitive info. However, if somebody does that, it would be nice to have an option to at least disable it from the default push output. As it wasn't present before in v7.

Best regards,
K.M.

@gururajsh
Copy link
Member

Thank you for your submission. Will discuss this with the team and update here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants