Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utility GetHash.aspx could result in plaintext logging of password on server #364

Open
jbtule opened this issue Apr 3, 2023 · 2 comments

Comments

@jbtule
Copy link

jbtule commented Apr 3, 2023

From the docs

From version 2.3.0, you can also generate a password hash from url (thanks jol64). syntax: https://server/myrtille/GetHash.aspx?password=password

I went to check the source to see if there was a possible alternate usage of that handler using a post and Request.Form but there isn't.

String password = Request.QueryString["Password"];

Query strings are often logged on webservers, not something you want to happen with a clear text password. I suggest at least having alternate post version and recommending it, if not replacing it outright for poor practice.

@deezed420
Copy link

Not a bad idea.

@deezed420
Copy link

I think you should put a pull request for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants