Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add _sync_id for collections #171

Open
sunkup opened this issue Aug 28, 2024 · 4 comments · May be fixed by #187
Open

Add _sync_id for collections #171

sunkup opened this issue Aug 28, 2024 · 4 comments · May be fixed by #187
Assignees
Labels
enhancement New feature or request jtx board

Comments

@sunkup
Copy link
Member

sunkup commented Aug 28, 2024

For https://github.com/bitfireAT/davx5/issues/603 .

Should:

@sunkup sunkup added the refactoring Quality improvement of existing functions label Aug 28, 2024
@patrickunterwegs patrickunterwegs linked a pull request Nov 22, 2024 that will close this issue
@patrickunterwegs
Copy link
Member

Hi @rfc2822 , hi @sunkup ,
I have added the column to jtx Board in a feature branch which is currently in an open pull request:
TechbeeAT/jtxBoard#1638

I have created a new pull request here for the update of the contract.
As I wasn't sure at what place you imagined to put the value in jtx Board, I have stopped there and would rather leave this up to you.

I assume that the minVersion of jtxBoard also needs to be updated in DAVx5 once this is done. Please use the following version codes:
versionCode = 210000000
versionName = "2.10.00"

There is a release in the pipeline where I wouldn't add this change yet (2.9.3), if you're sure that this column is exactly what you need, then I'd merge it right after the release. Are you sure about it?
As this creates an updated version dependency I'd like to release this change a couple of weeks before you do the DAVx5 release.
Please keep me updated about when you would release it in DAVx5.

@rfc2822
Copy link
Member

rfc2822 commented Nov 24, 2024

As I wasn't sure at what place you imagined to put the value in jtx Board, I have stopped there and would rather leave this up to you.

I can do the code in davx5 then.

versionCode = 210000000
versionName = "2.10.00"

👍🏻 Have added it to the PR.

There is a release in the pipeline where I wouldn't add this change yet (2.9.3), if you're sure that this column is exactly what you need, then I'd merge it right after the release. Are you sure about it?

Yes, sounds good!

As this creates an updated version dependency I'd like to release this change a couple of weeks before you do the DAVx5 release. Please keep me updated about when you would release it in DAVx5.

If I understand it correctly, the column would be available since the version after the next version (which is released to be soon):

  1. jtxBoard, next version, without sync_id – soon
  2. jtxBoard, version after next version, with sync_id
  3. Then a few weeks.
  4. DAVx5 release that requires sync_id

Correct?

Is there a rough plan when you want to release the version after the next version? We can do other things in DAVx5 until then.

@rfc2822 rfc2822 changed the title Add _sync_id property [jtx Board] Add _sync_id for collections Nov 24, 2024
@rfc2822 rfc2822 added jtx board enhancement New feature or request refactoring Quality improvement of existing functions and removed refactoring Quality improvement of existing functions enhancement New feature or request labels Nov 24, 2024
@rfc2822 rfc2822 changed the title [jtx Board] Add _sync_id for collections Add _sync_id for collections Nov 24, 2024
@sunkup
Copy link
Member Author

sunkup commented Nov 25, 2024

👍🏻 Have added it to the PR.

@rfc2822 Does the PR need any further changes? I have started working on https://github.com/bitfireAT/davx5/pull/627 which now only waits for this one to be merged.

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request jtx board
Projects
Status: Todo
Development

Successfully merging a pull request may close this issue.

3 participants