-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix source fields in Chart.yaml files #901
Comments
Hi John, Could you please paste a link to those fields that you mean? |
Let me be clear that this is not an issue that would affect anyone trying to use the operator. Its more of a perception thing so really minor. Here is a link to a line
so that field in a Chart.yaml is to provide anyone using the chart where the source code for where the chart resides. AFAIK. Most of our sources point to the upstream Istio, but properly the source for these charts is banzaicloud/istio-operator. Again pretty minor. Rarely - maybe never would someone really use this field and get confused. I happened to notice it so I thought I would record it. It is fine if you want to close it with no change. It is easy to fix though. |
I see now. These are internal charts though and not supposed to be used from the outside as helm charts, so I don't see much upside of the change. Feel free to a create a PR though and we can merge it or we can close this issue, both are fine to me. |
Describe the bug
Minor detail - but many of the "Source fields" in the Chart.yaml files point to istio upstream repos. Mostly we want to point to the banzai istio operator or maybe the eti/istio code. This this is an optional field and 2nd order documentation its pretty minor priority.
Steps to reproduce the issue:
NA
Expected behavior
NA
Screenshots
If applicable, add screenshots to help explain your problem.
Additional context
Add any other context about the problem like release number version, branch, etc.
The text was updated successfully, but these errors were encountered: