Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API cleanup #426

Closed
glaeqen opened this issue Apr 7, 2021 · 10 comments
Closed

API cleanup #426

glaeqen opened this issue Apr 7, 2021 · 10 comments

Comments

@glaeqen
Copy link
Contributor

glaeqen commented Apr 7, 2021

Effort to standardize API across HAL & BSCs.

@glaeqen
Copy link
Contributor Author

glaeqen commented Apr 7, 2021

As far as I could see, discussion sorta started already in #357. Nonetheless, properly tracked issue seems more appropriate for such thing.

@bradleyharden
Copy link
Contributor

Here's another proposed change. I would like to change target_device to pac. At the very least, maybe we could support both. Thoughts?

@Sympatron
Copy link
Contributor

Maybe we could review the unproven feature. Last time I looked a lot of basic stuff was "unproven" (I think because the traits were unproven in embedded-hal).

@Sympatron
Copy link
Contributor

Here's another proposed change. I would like to change target_device to pac. At the very least, maybe we could support both. Thoughts?

Seems like this is already part of PR #357.

@bradleyharden
Copy link
Contributor

I meant at the HAL level, not the BSP level. I don't think that PR affects the HAL name.

@bradleyharden
Copy link
Contributor

@Sympatron, I would expect unproven to disappear with embedded-hal 1.0, but who knows when that will be.

@Sympatron
Copy link
Contributor

Thinking about the unproven thing more, I came to the conclusion that we probably should not mark whole modules as "unproven" just because they implement some unproven trait. Everything else in these modules is "proven" (to the same degree as most of the hal). So I would vote to mark only the e-h trait impls as unproven.

@TDHolmes
Copy link
Contributor

TDHolmes commented Oct 9, 2021

Rename imports across the HAL and the BSPs to increase consistency and clarity. (open discussion)
PR XXX

done in #491

@ianrrees
Copy link
Contributor

It seems like the work discussed here has all been done, any reason not to close this?

@glaeqen
Copy link
Contributor Author

glaeqen commented Sep 1, 2024

I think this issue got outdated considering that I stopped following up on the changes that happened in the meantime. We can close it.

@glaeqen glaeqen closed this as completed Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants