Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add markdown-link-check with pre-commit #1360

Open
jbampton opened this issue Apr 23, 2024 · 2 comments · May be fixed by #1366
Open

Add markdown-link-check with pre-commit #1360

jbampton opened this issue Apr 23, 2024 · 2 comments · May be fixed by #1366
Assignees
@jbampton
Labels
in progress

Comments

@jbampton
Copy link
Member

Expected behavior

We should have all valid and working links and test for broken links

Actual behavior

Without an automated link check sometimes broken links are added and others become out of date.

Steps to reproduce the problem

Setup config file

https://github.com/tcort/markdown-link-check?tab=readme-ov-file#run-as-a-pre-commit-hook

  • install pre-commit
  • install the hooks
  • run pre-commit run --all-files

Settings

Sedona version = master

Apache Spark version = ?

Apache Flink version = ?

API type = Scala, Java, Python?

Scala version = 2.11, 2.12, 2.13?

JRE version = 1.8, 1.11?

Python version = ?

Environment = Standalone, AWS EC2, EMR, Azure, Databricks?
@jiayuasu
Copy link
Member

+1, let's have this!

@jbampton
Copy link
Member Author

I am working now on this issue. Thanks

@jbampton jbampton linked a pull request Apr 25, 2024 that will close this issue
Draft
@jbampton jbampton self-assigned this Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbampton jbampton

Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CI] Add lychee link checker with pre-commit jbampton/sedona
2 participants
@jbampton @jiayuasu