Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert sort to partial_sort when the table is unbounded #13807

Open
berkaysynnada opened this issue Dec 17, 2024 · 0 comments
Open

Convert sort to partial_sort when the table is unbounded #13807

berkaysynnada opened this issue Dec 17, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@berkaysynnada
Copy link
Contributor

berkaysynnada commented Dec 17, 2024

Is your feature request related to a problem or challenge?

in fn replace_with_partial_sort, there is a check

        if !child.execution_mode().is_unbounded() {
            return Ok(plan);
        }

Isn't it better to have partial sorts even if the source is bounded?

Describe the solution you'd like

Remove this check and always convert sorts to partial sorts if the requirements and properties allow

Describe alternatives you've considered

No response

Additional context

I guess it would heavily depend on the way how the data is ordered, and what is the rest of the plan, but a few benchmark results perhaps will make it more clear

@berkaysynnada berkaysynnada added the enhancement New feature or request label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant