Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAMEL-21559, mongodb: insertOne instead of replaceOne when saving without _id #16604

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thomas-gantenbein-tga
Copy link
Contributor

Description

The current implementation of the mongodb save operation forces mongodb to scan the whole collection when a document is saved without _id. This change makes an insert if no _id is given, instead of making an upsert with a filter condition that can never be satisfied. The behaviour for the save operation with _id remains untouched.

See also https://camel.zulipchat.com/#narrow/channel/257298-camel/topic/mongodb.20save.20operation.20performance

Copy link
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟

🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run

  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot.

  • You can label PRs using build-all, build-dependents, skip-tests and test-dependents to fine-tune the checks executed by this PR.

  • Build and test logs are available in the Summary page. Only Apache Camel committers have access to the summary.

  • ⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants