Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix audio controller fragment and overlapping fragment #458

Merged
merged 1 commit into from
Jun 22, 2020
Merged

Fix audio controller fragment and overlapping fragment #458

merged 1 commit into from
Jun 22, 2020

Conversation

shivammaindola
Copy link
Contributor

Fix: #456 and #457

@shivammaindola
Copy link
Contributor Author

@cpg @csoni111 can you please review this PR?

@chirag-jn chirag-jn self-assigned this Jun 18, 2020
@chirag-jn chirag-jn added the bug label Jun 18, 2020
@chirag-jn chirag-jn linked an issue Jun 21, 2020 that may be closed by this pull request
audio_controller_fragment is overlapping over castMiniController #457
Open
@chirag-jn
Copy link
Member

Stopping Music when you are changing the share should be an expected behavior. @cpg you can elaborate on it further. Hiding music activity when moving between folders works fine for me.

@chirag-jn chirag-jn added the on hold Hold on there, buddy! label Jun 21, 2020
@cpg cpg merged commit 811896b into amahi:beta Jun 22, 2020
@cpg cpg mentioned this pull request Jun 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chirag-jn chirag-jn chirag-jn approved these changes

Assignees

@chirag-jn chirag-jn

Labels
bug on hold Hold on there, buddy!
Projects
None yet
Milestone
No milestone
3 participants
@shivammaindola @chirag-jn @cpg