-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only Require Faraday Multipart if Faraday Version >= 2 #392
Comments
ajGingrich
changed the title
Only Require Faraday Multi-part if Faraday Version >= 2
Only Require Faraday Multipart if Faraday Version >= 2
Dec 1, 2023
ajGingrich
added a commit
to ajGingrich/ruby-openai
that referenced
this issue
Dec 1, 2023
Only Require Faraday Multipart if Faraday Version is greater than 2 because Farady V1 inlcudes the gem already. alexrudall#392
ajGingrich
added a commit
to ajGingrich/ruby-openai
that referenced
this issue
Dec 1, 2023
Only Require Faraday Multipart if Faraday Version is greater than 2 because Farady V1 includes the gem already. alexrudall#392
ajGingrich
added a commit
to ajGingrich/ruby-openai
that referenced
this issue
Dec 1, 2023
Only Require Faraday Multipart if Faraday Version is greater than 2 because Faraday V1 includes the gem already. alexrudall#392
3 tasks
ajGingrich
added a commit
to ajGingrich/ruby-openai
that referenced
this issue
Dec 1, 2023
Only Require Faraday Multipart if Faraday Version is greater than 2 because Faraday V1 includes the gem already. alexrudall#392
ajGingrich
added a commit
to ajGingrich/ruby-openai
that referenced
this issue
Dec 1, 2023
Only Require Faraday Multipart if Faraday Version is greater than 2 because Faraday V1 includes the gem already. alexrudall#392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
After upgrading from 3.7.0 to the latest version, I see warnings related to already initialized constants from Faraday Multipart. This is because I'm still using Faraday 1.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
Only require faraday multipart if the Faraday version is >= 2 so the constants are not required twice.
Screenshots
Additional context
It should be a one line fix here
ruby-openai/lib/openai.rb
Line 2 in 80da193
I can make the change if desired.
The text was updated successfully, but these errors were encountered: