Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Require Faraday Multipart if Faraday Version >= 2 #392

Open
ajGingrich opened this issue Dec 1, 2023 · 0 comments
Open

Only Require Faraday Multipart if Faraday Version >= 2 #392

ajGingrich opened this issue Dec 1, 2023 · 0 comments

Comments

@ajGingrich
Copy link

ajGingrich commented Dec 1, 2023

Describe the bug

After upgrading from 3.7.0 to the latest version, I see warnings related to already initialized constants from Faraday Multipart. This is because I'm still using Faraday 1.

To Reproduce

Steps to reproduce the behavior:

  1. Use Faraday 1.1
  2. Use latest ruby-openai
  3. See warnings below
/usr/local/bundle/gems/faraday-multipart-1.0.4/lib/faraday/multipart.rb:15: warning: already initialized constant Faraday::FilePart
/usr/local/bundle/gems/faraday-1.1.0/lib/faraday/file_part.rb:53: warning: previous definition of FilePart was here

Expected behavior

Only require faraday multipart if the Faraday version is >= 2 so the constants are not required twice.

Screenshots

image

Additional context

It should be a one line fix here

require "faraday/multipart"

require 'faraday/multipart' if Gem::Version.new(Faraday::VERSION) >= Gem::Version.new('2.0')

I can make the change if desired.

@ajGingrich ajGingrich changed the title Only Require Faraday Multi-part if Faraday Version >= 2 Only Require Faraday Multipart if Faraday Version >= 2 Dec 1, 2023
ajGingrich added a commit to ajGingrich/ruby-openai that referenced this issue Dec 1, 2023
Only Require Faraday Multipart if Faraday Version is greater than
2 because Farady V1 inlcudes the gem already.

alexrudall#392
ajGingrich added a commit to ajGingrich/ruby-openai that referenced this issue Dec 1, 2023
Only Require Faraday Multipart if Faraday Version is greater than
2 because Farady V1 includes the gem already.

alexrudall#392
ajGingrich added a commit to ajGingrich/ruby-openai that referenced this issue Dec 1, 2023
Only Require Faraday Multipart if Faraday Version is greater than
2 because Faraday V1 includes the gem already.

alexrudall#392
ajGingrich added a commit to ajGingrich/ruby-openai that referenced this issue Dec 1, 2023
Only Require Faraday Multipart if Faraday Version is greater than
2 because Faraday V1 includes the gem already.

alexrudall#392
ajGingrich added a commit to ajGingrich/ruby-openai that referenced this issue Dec 1, 2023
Only Require Faraday Multipart if Faraday Version is greater than
2 because Faraday V1 includes the gem already.

alexrudall#392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant