Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable installation of go on ppc64/ppc64le systems #517

Open
kishen-v opened this issue Nov 25, 2024 · 3 comments · May be fixed by #518
Open

Enable installation of go on ppc64/ppc64le systems #517

kishen-v opened this issue Nov 25, 2024 · 3 comments · May be fixed by #518
Labels
feature request New feature or request to improve the current logic

Comments

@kishen-v
Copy link

Description:
Enable setup-go on ppc64le systems. I do see there is a block of code to related to this, which is commented.

setup-go/src/system.ts

Lines 27 to 29 in 41dfa10

// case 'ppc':
// arch = 'ppc64';
// break;

However, with NodeJS not having the capability to determine the endianness of the host using the generic os.arch() call, it is imperative to have os.endianness() differentiate and pick bundles for installation on ppc64/ppc64le systems.

I am using a self-hosted ppc64le system, on which the issue was observed.

Run actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed
  with:
    go-version: 1.[2](https://github.com/kishen-v/cri-o/actions/runs/11957574849/job/33337601992#step:3:2)3
    check-latest: false
    token: ***
    cache: true
  env:
    GO_VERSION: 1.2[3](https://github.com/kishen-v/cri-o/actions/runs/11957574849/job/33337601992#step:3:3)
    CONMON_BINARY: /usr/local/bin/conmon
Setup go version spec 1.23
Found in cache @ /home/ghrunner/runner/_layout/_work/_tool/go/1.23.3/ppc6[4](https://github.com/kishen-v/cri-o/actions/runs/11957574849/job/33337601992#step:3:4)
Added go to the path
Successfully set up Go version 1.23
/bin/sh: line 1: /home/ghrunner/runner/_layout/_work/_tool/go/1.23.3/ppc[6](https://github.com/kishen-v/cri-o/actions/runs/11957574849/job/33337601992#step:3:6)4/bin/go: cannot execute binary file: Exec format error
Error: Command failed: go env GOPATH
/bin/sh: line 1: /home/ghrunner/runner/_layout/_work/_tool/go/1.23.3/ppc64/bin/go: cannot execute binary file: Exec format error

Justification:
This change can help to install go on ppc64/ppc64le systems using setup-go, which are added as self-hosted runners.

Are you willing to submit a PR?
Yes.

@kishen-v kishen-v added feature request New feature or request to improve the current logic needs triage labels Nov 25, 2024
@kishen-v kishen-v linked a pull request Nov 25, 2024 that will close this issue
2 tasks
@priyagupta108
Copy link
Contributor

Hi, @kishen-v 👋 Thank you for the feature request, we will investigate it and get back to you as soon as we have some feedback.

@kishen-v
Copy link
Author

Hi @priyagupta108, thank you for looking into the issue!

I've also raised a PR #518 for this feature. I'd be happy to accommodate suggestions/reviews.

Thanks!

@kishen-v
Copy link
Author

kishen-v commented Dec 3, 2024

Hi @priyagupta108, a gentle reminder for your inputs and review of the associated PR that fixes the issue.
Please take a look when time permits.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants