You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
When using custom container hooks, using a docker step with multiline args is being forwarded with the wrong formatting, it's removing newlines (/n) and tabs/indent (/t) or any sort of trailing space.
To Reproduce
Use the base build of runner-container-hooks when using github-runner-scale-set on k8s to have self-hosted runners.
Run a workflow like the following:
runs:
using: "docker"image: "ubuntu:latest"entrypoint: "/bin/bash"args:
- "-c"
- | cd /github/workspace if [[ ! -z true ]]; then package_overrides="a b c" for package_override in $package_overrides; do echo "package_override: $package_override" done fi exit $exit_code
run the action, and it will show how the multiline argument has been converted into a single line, respecting only /n/n not \n ot \t or trailing spaces
by adding logs to runner-container-hooks, we prove that the input being sent to the container has been converted to a list of strings and has already trimmed newlines, tabs and spaces
Expected behavior
The hook should receive the text with the right format, not a splitted list of strings that loses spaces/newlines on merging it back.
It looks like this handler line could be causing the issue:
Describe the bug
When using custom container hooks, using a docker step with multiline
args
is being forwarded with the wrong formatting, it's removing newlines (/n) and tabs/indent (/t) or any sort of trailing space.To Reproduce
github-runner-scale-set
on k8s to have self-hosted runners.run the action, and it will show how the multiline argument has been converted into a single line, respecting only
/n/n
not\n
ot\t
or trailing spacesby adding logs to runner-container-hooks, we prove that the input being sent to the container has been converted to a list of strings and has already trimmed newlines, tabs and spaces
Expected behavior
The hook should receive the text with the right format, not a splitted list of strings that loses spaces/newlines on merging it back.
It looks like this handler line could be causing the issue:
Runner Version and Platform
2.321.0
OS of the machine running the runner?
Linux
What's not working?
Hook input not correctly shipped.
Job Log Output
Not applicable
Runner and Worker's Diagnostic Logs
Not applicable
The text was updated successfully, but these errors were encountered: