Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Enable to add annotations to the listeners #3815

Open
laserpedro opened this issue Nov 20, 2024 · 2 comments
Open

[FEAT] Enable to add annotations to the listeners #3815

laserpedro opened this issue Nov 20, 2024 · 2 comments
Labels
community Community contribution enhancement New feature or request needs triage Requires review from the maintainers

Comments

@laserpedro
Copy link

laserpedro commented Nov 20, 2024

What would you like added?

listenerTemplate:
    metadata:
      annotations:
      prometheus.io/scrape: true
      prometheus.io/path: /metrics
      prometheus.io/port: 8080

Why is this needed?

We need this to be able to scrap the listener metrics that are very useful for jobs, steps monitoring

Additional context

Let me know if you want more.

@laserpedro laserpedro added community Community contribution enhancement New feature or request needs triage Requires review from the maintainers labels Nov 20, 2024
Copy link
Contributor

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

@jef
Copy link

jef commented Dec 2, 2024

You can add metrics to the listener, but you're missing the spec.containers:

listenerTemplate:
  metadata:
    annotations:
      prometheus.io/scrape: true
      prometheus.io/path: /metrics
      prometheus.io/port: 8080
  spec:
    containers:
      - name: listener

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution enhancement New feature or request needs triage Requires review from the maintainers
Projects
None yet
Development

No branches or pull requests

2 participants