Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide ads for authenticated users #160

Open
GoldenChaos opened this issue Jul 19, 2018 · 2 comments
Open

Hide ads for authenticated users #160

GoldenChaos opened this issue Jul 19, 2018 · 2 comments
Assignees
@Pysis868
Labels
enhancement
Milestone
0.7

Comments

@GoldenChaos
Copy link

This was pull requested, but upon testing I found that it actually currently completely disables ads. Oops 😛
@GoldenChaos GoldenChaos added this to the 0.7 milestone Jul 19, 2018
@Pysis868
Copy link
Contributor

Checked on staging.
image

Both ad elements exist. The proper ones are hidden and shown, just not populated.
I see we have the google ad tracking file in source control.
I saw the ads on production, but I guess this is the old code since you reverted #159 in production.

@GoldenChaos
Copy link
Author

GoldenChaos commented Jul 22, 2018 •
edited
Loading

This is not true @Pysis868 - the ads are populated but not shown, I've just finished testing. Something is hiding the ad related to your changes. The ad shows up properly when your changes are reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pysis868 Pysis868

Labels
enhancement
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
2 participants
@GoldenChaos @Pysis868