Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Line2，Modify props.points, but it does not take effect #493

Open
5 tasks done
devick opened this issue Sep 13, 2024 · 6 comments · May be fixed by #551
Open
5 tasks done

Line2，Modify props.points, but it does not take effect #493

devick opened this issue Sep 13, 2024 · 6 comments · May be fixed by #551
Assignees
@andretchen0
Labels
bug Something isn't working p2-nice-to-have Not breaking anything but nice to have (priority)

Comments

@devick
Copy link

devick commented Sep 13, 2024

Describe the bug

I used Line2 to add a point to the props.points, but it doesn't seem to render.
Specifically, points larger than the original array were not rendered, but points smaller than the original array were re rendered

Reproduction

https://stackblitz.com/edit/tresjs-basic-kftrax?file=src%2Fcomponents%2FTheExperience.vue

Steps to reproduce

No response

System Info

No response

Used Package Manager

npm

Code of Conduct
@JaimeTorrealba
Copy link
Member

My friend help me here please @andretchen0

@andretchen0
Copy link
Contributor

andretchen0 commented Oct 2, 2024 •
edited
Loading

There was a brief discussion about this on Discord the last time it was brought up.

THREE doesn't allow resizing buffers after they're created. It was decided that Cientos shouldn't paper over that.

Is that something we want to rethink, work around, or possibly warn about?

@JaimeTorrealba @alvarosabu

@JaimeTorrealba
Copy link
Member

Maybe we have to put this in the docs explicitly.
Can you address that? @andretchen0

@andretchen0
Copy link
Contributor

I have a proposal, but maybe it's easier to discuss on Discord. I'll post there.

@andretchen0
Copy link
Contributor

@devick Thanks for filing the issue!

@andretchen0 andretchen0 self-assigned this Oct 3, 2024
@alvarosabu alvarosabu added the bug Something isn't working label Oct 17, 2024
@alvarosabu
Copy link
Member

Hey @andretchen0 thanks for taking this one, can you please add the prioritization labels to this one (p1..p5)? Thanks

@andretchen0 andretchen0 added the p2-nice-to-have Not breaking anything but nice to have (priority) label Oct 17, 2024
@andretchen0 andretchen0 mentioned this issue Nov 18, 2024
Closed
@andretchen0 andretchen0 linked a pull request Dec 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andretchen0 andretchen0

Labels
bug Something isn't working p2-nice-to-have Not breaking anything but nice to have (priority)
Projects
Team Board
Status: In Progress
Milestone
No milestone
4 participants
@alvarosabu @devick @andretchen0 @JaimeTorrealba