Add support for trace_v3 schema in messaging queues #6663
Merged
+91
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 7460888 in 32 seconds
More details
- Looked at
383lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. pkg/query-service/constants/constants.go:93
- Draft comment:
The environment variableKAFKA_SPAN_EVALhas been changed fromfalsetotrue. This alters the default behavior of the application and should be documented or communicated to the team. - Reason this comment was not posted:
Confidence changes required:50%
The PR changes the environment variableKAFKA_SPAN_EVALfromfalsetotrue. This change should be highlighted as it affects the default behavior of the application.
Workflow ID: wflow_HbsIa5fMPHIOmt9i
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
nityanandagohain
changed the title
nityanandagohain
approved these changes
Dec 18, 2024
| @@ -90,7 +90,7 @@ func EnableHostsInfraMonitoring() bool { | |||
| return GetOrDefaultEnv("ENABLE_INFRA_METRICS", "true") == "true" | |||
| } | |||
|
|
|||
| var KafkaSpanEval = GetOrDefaultEnv("KAFKA_SPAN_EVAL", "false") | |||
| var KafkaSpanEval = GetOrDefaultEnv("KAFKA_SPAN_EVAL", "true") | |||
There was a problem hiding this comment.
I am re-iterating my position on this as mentioned here #6661 (comment), this change should not be enabled by default. Please revert it.
|
With the trace v3, the bucket filter must exist. Otherwise, they can be really slow (it would have been better if it was suggested during review) #6666, @shivanshuraj1333, please sync with @nityanandagohain if you need to understand the bucketing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supports trace_v3 now
Important
Update SQL queries to support
trace_v3schema and enable Kafka span evaluation by default.sql.goto usesignoz_traces.distributed_signoz_index_v3instead ofv2.serviceNamewithresource_string_service$$nameandmsgSystemwithattribute_string_messaging$$systemin SQL queries.KafkaSpanEvaldefault value totrueinconstants.go.This description was created by
for 7460888. It will automatically update as commits are pushed.