Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 front-end bugs #6614

Open
941477276 opened this issue Dec 11, 2024 · 3 comments
Open

3 front-end bugs #6614

941477276 opened this issue Dec 11, 2024 · 3 comments

Comments

@941477276
Copy link

941477276 commented Dec 11, 2024

Bug description

bug1:New alarm channel has no form verification

When adding an alarm channel, the alarm channel name, web address, and email are not verified in the form, resulting in an interface error.
Image

bug2:After searching for a card in the dashboard, clicking the Clear button does not execute the search again

Image

bug3:The useAlertHistoryQueryParams hooks is not accurate in judging whether relativeTime is null

If the address is http://localhost:3301/alerts/history?ruleId=1&relativeTime=null, the relativeTime obtained by params.get(QueryParams.relativeTime) is a string of 'null' instead of null, so the statement after ?? will not be executed
Image

Fix:
Image

Version information

  • Signoz version: 0.5.7
  • Browser version: Chrome 127.0.6533.89
  • Your OS and version: Windows 10
  • Your CPU Architecture(ARM/Intel): Intel(R) Core(TM) i5-10600
Copy link

welcome bot commented Dec 11, 2024

Thanks for opening this issue. A team member should give feedback soon. In the meantime, feel free to check out the contributing guidelines.

@pranay01
Copy link
Collaborator

pranay01 commented Dec 11, 2024

@941477276 can you share where have you setup this and docs you followed?

@941477276
Copy link
Author

Share the repaired code file and location?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants