Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Typing in masked fields doesn't feel responsive #5060

Open
2 tasks done
kpeatt opened this issue Dec 9, 2024 · 2 comments
Open
2 tasks done

[Bug]: Typing in masked fields doesn't feel responsive #5060

kpeatt opened this issue Dec 9, 2024 · 2 comments
Labels
Area: @shopify/cli-kit @shopify/cli-kit package issues Type: Bug Something isn't working

Comments

@kpeatt
Copy link

kpeatt commented Dec 9, 2024

Sorry, recreated #5030 because I accidentally closed it.

Please confirm that you have:

  • Searched existing issues to see if your issue is a duplicate. (If you’ve found a duplicate issue, feel free to add additional information in a comment on it.)
  • Reproduced the issue in the latest CLI version.

In which of these areas are you experiencing a problem?

App

Expected behavior

Typing in the CLI is fast and responsive and registers every character.

Actual behavior

Typing input into the CLI in any of the places I've encountered it is extremely laggy and unresponsive. Because this is usually a masked input like entering your store password, it's hard to know if you've typed the correct letters because they don't always register.

Example video: https://share.cleanshot.com/JrzKf7ds

Verbose output

Reproduction steps

  1. Somehow trigger a masked input
  2. Type into the input at a reasonable pace
  3. Get frustrated

Operating System

Mac OS Sequoia 15.1.1 (24B2091)

Shopify CLI version (shopify --version)

@shopify/cli/3.70.0 darwin-arm64 node-v22.11.0

Shell

zsh

Node version (run node -v if you're not sure)

No response

What language and version are you using in your application?

No response

@kpeatt kpeatt added the Type: Bug Something isn't working label Dec 9, 2024
@graygilmore graygilmore changed the title [Bug]: <YOUR ISSUE TITLE> [Bug]: Typing in masked fields doesn't feel responsive Dec 9, 2024
@frandiox frandiox added the Area: @shopify/cli-kit @shopify/cli-kit package issues label Dec 10, 2024
@isaacroldan
Copy link
Contributor

I can't reproduce it on my mac, @frandiox @graygilmore I believe this is only used for store passwords? Are you able to reproduce?

@graygilmore
Copy link
Contributor

🤔 I'm also unable to reproduce with both shopify theme dev and shopify app dev. Kyle maybe there's something with your specific setup/terminal/plugins? I don't think we've seen this broadly reported anywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: @shopify/cli-kit @shopify/cli-kit package issues Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants