-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: 502 Response from Theme Kit GraphQL themeFilesUpsert
mutation when using CI/CD
#5031
Comments
I'm quite sure this related to having relatively large files in the theme. We have assets in the JS folder up to ~160KB. When I remove them, the issue disappears. |
Correction: This is caused by having large theme files. This particular theme has a ~4MB file that is the culprit. When I remove it, the issue disappears. I will work on the theme to address that file. I'll also leave this issue open for Shopify to determine if it is something that changed or needs to be resolved since it coincided with the 3.71.1 release. It's also curious that when I encountered the issue, I was unable to reproduce it when using the CLI after logging in interactively. I only saw this while using the env vars for CI/CD. |
Correction to the correction: This is still happening today in new branches even after removing all files > 250KB from the theme. Only after removing all files in Curiously, the themes are actually being created in the store, but the CLI reports a 502 response and errors out. |
Also noticing this, fairly new behavior within the past week or two. Request ID to review;
|
Thank you both for the report. Can you confirm that you're both using the We'll be looking at working on a fix for this shortly but in the mean time you can pin to |
@graygilmore thank you for the follow up. I am not using the |
I have same issue |
We're also encountering this issue. Request IDs: |
same, request ID: |
I had to go back to c0dd49b#diff-3fd7a9e29cd4a60ea93e98a1479c9766e74847f8170c7850792d59ba95522f14 |
Hey all! Thanks for some additional request IDs. We're aware of the issue and will be looking at getting a fix out next week. Appreciate everyone's patience ❤ |
Please confirm that you have:
In which of these areas are you experiencing a problem?
Theme
Expected behavior
shopify theme push
creates a theme on my store using the same theme files that successfully created themes two days priorActual behavior
This issue coincided with #5010. After resolving that issue by removing empty theme files from our repo we encountered this problem.
Our CI/CD pipeline in GitHub actions fails consistently and has this 502 response. (EDIT: I removed some extraneous information about my local testing that I think was a red herring.)
Verbose output
Note: The verbose output includes the contents of all theme files. This content is very large because it contains all theme files. Some of these files are relatively large JS bundles (80-160KB). I have also redacted all template content to protect PI. I also do not have the full output because my bash history doesn't go far enough back. This is starting with what was available:
Verbose output
Reproduction steps
Reference: Shopify documentation for CI/CD
assets
folder for the theme (4MB, for example)shopify auth logout
export SHOPIFY_CLI_THEME_TOKEN="<THEME ACCESS TOKEN>"
export SHOPIFY_FLAG_STORE="<STORE>"
export SHOPIFY_FLAG_FORCE="1"
shopify theme push --theme="cli-testing-ubuntu8-CI" --unpublished --verbose
Operating System
Ubuntu 22.04.5 LTS
Shopify CLI version (
shopify --version
)3.71.1
Shell
bash
Node version (run
node -v
if you're not sure)v20.12.0 (locally) and v23.3.0 (GitHub actions)
What language and version are you using in your application?
Liquid, JS, YML, etc.
The text was updated successfully, but these errors were encountered: