-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PrivacyInfo.xcprivacy not included in framework via Carthage #2645
Comments
FYI, there is no need for a privacy file for RxSwift because it doesn't use any privacy related methods. Please post the text of the Apple review error. |
This is the Apple review:
After reading #2625, I guess this is a duplicate, I don't get why Apple is reviewing RxSwift like this though, and it is going to be a problem. |
I have no idea what "OneSignalOutcomes" is and it's not referenced anywhere in the RxSwift codebase. After Googling, I see that it is part of some other library, the "OneSignal-iOS-SDK". Are you including that library in your code? If not, do you know what OneSignalOutcomes is? |
Like you, I guess OneSignalOutcomes comes from OneSignal iOS SDK. We have nothing related to OneSignalOutcomes or OneSignal in our codebase. And, by the way, OneSignalOutcomes is the same SDK mentioned by Apple in #2625. I do not understand why OneSignal is linked to RxSwift, but both OneSignal and RxSwift are listed in the Apple documentation about privacy. Maybe asking Apple about that identification is the solution? |
Short description of the issue:
PrivacyInfo.xcprivacy
files are not added to Xcode project, therefore their are not included in frameworks when importing RXSwift via Carthage.Expected outcome:
When adding RxSwift as a dependency via Carthage, I except to include a framework with
PrivacyInfo.xcprivacy
to validate Apple review and avoid theITMS-91061
review error.What actually happens:
Privacy info files are not included, the Apple review raises an error
ITMS-91061
RxSwift/RxCocoa/RxBlocking/RxTest version/commit
6.8.0
Platform/Environment
How easy is to reproduce? (chances of successful reproduce after running the self contained code)
Xcode version:
Installation method:
I have multiple versions of Xcode installed:
(so we can know if this is a potential cause of your issue)
Level of RxSwift knowledge:
(this is so we can understand your level of knowledge
and formulate the response in an appropriate manner)
The text was updated successfully, but these errors were encountered: