Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having the list of sheets in a Google spreadsheet in a pop-menu (<select> tag) instead of a list of radio button. #7

Open
antoine2711 opened this issue Mar 19, 2020 · 5 comments

Comments

@antoine2711
Copy link
Member

Is your feature request related to a problem or area of OpenRefine? Please describe.
This is a small improvement to the interface to import Google Sheets data.

Describe the solution you'd like
In the import dialog, instead of showing a vertical list of radio button, just one popup-menu would save a lot a place.

Describe alternatives you've considered
Staying like this, that works.

Additional context
Example of what the interface is (1) and what it could be (2)
(1)
image

(2)
image

@thadguidry
Copy link
Member

thadguidry commented Mar 19, 2020

I think instead of a "popup list", it should just be a multi-selection list that has a small scroll bar next to it? Look at how this is done: https://jqueryui.com/selectable/#default Holding CTRL makes it multi-select, although that behavior could be changed so that holding CTRL button is not needed and instead each element in the list toggles (click once for on, click again for off) Like this: https://plugins.jquery.com/ui-selectableScroll/ DEMO HERE: http://karolyi.github.io/ui-selectableScroll/demo.html

I've added an issue for that particular Jquery plugin for a toggle selecting ability. Maybe the author will improve it, otherwise, we could customize it.

@antoine2711
Copy link
Member Author

I'm not sure I follow you. There can never be more than one sheet selected at the same time. It is one reason why a popup menu that just show the current choice is enough. I'm trying to avoid long list for spreadsheets with more than 10 sheets.
Why not just use https://api.jqueryui.com/1.10/menu/?

@wetneb
Copy link
Member

wetneb commented Mar 20, 2020

There can never be more than one sheet selected at the same time.

Just like the Excel importer can import multiple sheets at once, don't we want to have the same here? (I haven't checked if it is currently supported, but it sounds like this would be quite natural to make this uniform).

@kushthedude
Copy link
Member

I will take a look at it

@antoine2711
Copy link
Member Author

@wetneb : oh! Yes, indeed, the Excel importer can input many sheet in an Excel file. But no, gSheet importer can't do that. I'm not sure it would be very handy (meaning that it wouldn't save time). And, opening multiple sheet from the same import window implies a lot of change and coding, whereas this request is really a little cosmetic UI thing.

There can never be more than one sheet selected at the same time.

Just like the Excel importer can import multiple sheets at once, don't we want to have the same here? (I haven't checked if it is currently supported, but it sounds like this would be quite natural to make this uniform).

I would recommend multiple import it if it was an easy task to add multiple import as once, but I doesn't seems to be.

@wetneb wetneb transferred this issue from OpenRefine/OpenRefine Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants