Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Google integration when running OpenRefine behind a proxy #4

Open
wetneb opened this issue Oct 23, 2021 · 0 comments
Open

Enable Google integration when running OpenRefine behind a proxy #4

wetneb opened this issue Oct 23, 2021 · 0 comments

Comments

@wetneb
Copy link
Member

wetneb commented Oct 23, 2021

Posted by @matiasgarciaisaia at OpenRefine/OpenRefine#3627 (comment):

If OpenRefine runs behind an HTTPs reverse proxy, Jetty 6 doesn't set the correct client's schema on the HttpServletRequest object, causing the generated redirect_uri for OAuth to always be plain HTTP - which Google forbids for external OAuth applications.

Although OpenRefine is not designed to be hosted online, we are aware of a few places where this is done, and therefore those uses could benefit from making the Google integration usable in this context.

@matiasgarciaisaia proposed a PR which fixes this for Jetty 6: OpenRefine/OpenRefine#3627.

In the meantime we upgraded to Jetty 9. Therefore a new solution for this version of Jetty could be found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant