aadApp/create fails in BAMI tenants

[corinagum]

Describe the bug
Up until now, I have been able to use TTK to create bots in a BAMI tenant :)

Yesterday, I started running into a problem where botAad/create would fail when leaving bot id and password empty (in order to create a new bot)

While debugging, I found that if I changed the yml file generateClientSecret: false, the provisioning would get farther (step 3/7 instead of 1/7) but ultimately fail because the password was not filled in. (Sorry I don't have a screencap of this part)

If I created a bot manually in Azure Portal but didn't generate a secret, populated the bot id then ran the bot I got an error aadApp/create failed

As a workaround, I am able to create a bot manually and generate the password in Azure Portal, fill in my env files, and then run the bot. I have checked with BAMI tenant reps and there has not been any restrictions set on bots with secrets.

To Reproduce
Steps to reproduce the behavior:

1. Use a BAMI tenant login
2. Open an app and make sure bot id and password are blank
3. Run the bot, expecting to create a bot with password
4. See error

Expected behavior
I would expect the ability to create a bot through the TTK flow. I spoke with my BAMI representative and there is no known changes to BAMI requirements restricting bots with secrets.

VS Code Extension Information (please complete the following information):

• OS: Mac 15.1.1
• Version (of TTK extension: tested on 5.10.1 and 5.11.2023112909

[microsoft-github-policy-service]

Thank you for contacting us! Any issue or feedback from you is quite important to us. We will do our best to fully respond to your issue as soon as possible. Sometimes additional investigations may be needed, we will usually get back to you within 2 days by adding comments to this issue. Please stay tuned.

[blackchoey]

@corinagum below error means you added a value for BOT_ID in the .env.xxx file, but didn't add a value for SECRET_BOT_PASSWORD. In this case, botAadApp/create will fail with this error per previous design.

I wasn't able to repro this issue with empty BOT_ID and SECRET_BOT_PASSWORD values. Can you share a sample project for me to have a try?

By the way, your title is talking about aadApp/create but seems the issue description is talking about botAadApp/create, please also let me know if you need further help for the aadApp/create action.