Seems Redundant loop in CommandList::writeBuffer in Vulkan Backend

[BlurryLight]

nvrhi/src/vulkan/vulkan-buffer.cpp

Lines 434 to 440 in 970bf53

	while (remaining > 0)
	{
	// vulkan allows <= 64kb transfers via VkCmdUpdateBuffer
	int64_t thisGulpSize = std::min(remaining, int64_t(commandBufferWriteLimit));
	// we bloat the read size here past the incoming buffer since the transfer must be a multiple of 4; the extra garbage should never be used anywhere
	thisGulpSize = (thisGulpSize + 3) & ~3ll;

thisGulpSize is rounded up to multiple of 4, so it should be greater equal than remaining.
There should be no second loop here.

Line 437 is also redundant, because it won't enter this branch if data size greater than 65536

nvrhi/src/vulkan/vulkan-buffer.cpp

Line 424 in 970bf53

if (dataSize <= commandBufferWriteLimit)

[apanteleev]

Thanks - I've removed the loop. I think it remained from an early implementation when only updateBuffer was used.
Closing.