New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validity TAA offset for MSAA #24

Open

lortael opened this issue Dec 6, 2024 · 0 comments

lortael commented Dec 6, 2024

Hi, in the TAA pass (https://github.com/NVIDIAGameWorks/donut/blob/main/src/render/TemporalAntiAliasingPass.cpp), the jittering offsets used with MSAA jittering are the following:

const float2 offsets[] = {
                float2(0.0625f, -0.1875f), float2(-0.0625f, 0.1875f), float2(0.3125f, 0.0625f), float2(-0.1875f, -0.3125f),
                float2(-0.3125f, 0.3125f), float2(-0.4375f, 0.0625f), float2(0.1875f, 0.4375f), float2(0.4375f, -0.4375f)
            };

The sum of the Y component equals 0.125. Won't this not being 0 leads to an image slightly shifted along the Y axis ?

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment