Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: allow disabling crashpad process #4966

Open
pushkin- opened this issue Dec 3, 2024 · 2 comments
Open

[Feature]: allow disabling crashpad process #4966

pushkin- opened this issue Dec 3, 2024 · 2 comments
Labels
feature request feature request

Comments

@pushkin-
Copy link

pushkin- commented Dec 3, 2024

Describe the feature/enhancement you need

somewhat related to this issue #4965

Setting that flag to true or false doesn't disable the crashpad-handler process.

Electron somehow manages to disable it and only runs it when crash reporting is running.

Would be nice to turn it off when we don't need it.

The scenario/use case where you would use this feature

remove extra process, save memory

How important is this request to you?

Nice to have. There are other ways to tackle this, but having official API support would be beneficial.

Suggested implementation

I feel like that IsCustomCrashReportingEnabled property should control whether that process runs.

What does your app do? Is there a pending deadline for this request?

No response

@pushkin- pushkin- added the feature request feature request label Dec 3, 2024
Copy link

github-actions bot commented Dec 3, 2024

Hi, @pushkin-!

It seems that your issue contains the word "crash". If you have not already, could you attach a crash dump as a comment?

WV2 crash dumps are located in a subfolder of the app's user data folder (UDF): <UDF>\EBWebView\Crashpad\reports\. By default, the user data folder is created in the app's folder with a name like <App Exe Name>.exe.WebView2. Refer to Crash Diagnostics for more information.

Thank you for your cooperation!

@aluhrs13
Copy link
Contributor

aluhrs13 commented Dec 9, 2024

I don't think this is something we'd strongly consider. Crashpad's memory usage is pretty much in the single digit MB, often <1MB. If we did, it wouldn't be tied to IsCustomCrashReportingEnabled (or would be a breaking change) - that's intended for the app to say "I'm handling the reporting of my crashes myself" which may or may not use the crash dumps gathered by WV2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request feature request
Projects
None yet
Development

No branches or pull requests

2 participants