Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm: various config file fixes #200047

Closed
wants to merge 1 commit into from
Closed

llvm: various config file fixes #200047

wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Dec 4, 2024

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Let's create config files that target aarch64 too. This is used as the
target by Python. See Homebrew/discussions#5778.

Also, use -isysroot instead of --sysroot so that our choice can be
overridden by setting SDKROOT. Fixes #197277.

@carlocab
llvm: various config file fixes
74a3146 
Let's create config files that target `aarch64` too. This is used as the
target by Python. See Homebrew/discussions#5778.

Also, use `-isysroot` instead of `--sysroot` so that our choice can be
overridden by setting `SDKROOT`. Fixes #197277.
@carlocab carlocab added the long build Set a long timeout for formula testing label Dec 4, 2024
@github-actions github-actions bot added the python Python use is a significant feature of the PR or issue label Dec 4, 2024
@carlocab carlocab mentioned this pull request Dec 4, 2024
Open
4 tasks
@carlocab
Copy link
Member Author

carlocab commented Dec 4, 2024

Cherry-picked onto #199909.

@carlocab carlocab marked this pull request as draft December 4, 2024 11:36
@carlocab carlocab added the rollup proposed It has been proposed that this PR's commits are cherry-picked and merged as a part of another PR label Dec 4, 2024
@madsmtm
Copy link

madsmtm commented Dec 4, 2024 •
edited
Loading

Also, use -isysroot instead of --sysroot so that our choice can be overridden by setting SDKROOT.

I don't think this will let users override by setting SDKROOT, it'll always prefer the value in -isysroot. But at least it also won't confusingly try to use different SDKs at compile and at link time, so definitely an improvement.

@carlocab carlocab mentioned this pull request Dec 5, 2024
Merged
@carlocab
Copy link
Member Author

carlocab commented Dec 7, 2024

Merged in #199909.

@carlocab carlocab closed this Dec 7, 2024
@carlocab carlocab deleted the llvm-cfg-files branch December 7, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
long build Set a long timeout for formula testing python Python use is a significant feature of the PR or issue rollup proposed It has been proposed that this PR's commits are cherry-picked and merged as a part of another PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

llvm: Clang doesn't use SDKROOT when linking
2 participants
@carlocab @madsmtm