Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom attributes #1192

Open
Spyna opened this issue May 19, 2022 · 8 comments
Open

Add custom attributes #1192

Spyna opened this issue May 19, 2022 · 8 comments

Comments

@Spyna
Copy link

Spyna commented May 19, 2022

I'd like to add a feature to generate custom random attributes.

Spyna pushed a commit to Spyna/hashlips_art_engine that referenced this issue May 19, 2022
@bolshoytoster
Copy link

@Spyna can you not just have a layer of fully transparent images with the attribute names?

@Spyna
Copy link
Author

Spyna commented May 19, 2022

If you want to range between 100 values (maybe with numeric values) you don't want to create 100 files.

@Spyna
Copy link
Author

Spyna commented May 19, 2022

I created the pull request #1193 to add this feature

@bolshoytoster
Copy link

@Spyna fair enough, but your PR is unlikely to be merged because HashLips has been inactive for a few months.

Also, you shouldn’t create an extra file (src/attributes.config.js), just put the extra config in src/config.js.

And in addCustomMetadata you could add some extra spacing, at least a space after the if and before the else.

@Spyna
Copy link
Author

Spyna commented May 19, 2022

How come the project is at a standstill? Is there another one active?

It is better to add another small file that does one thing instead of adding more functionality to an already large file. It's called the single responsibility principle in programming.

For the spacing, I followed the style of the rest of the code, in which there are no spaces after ifs

@bolshoytoster
Copy link

@Spyna

How come the project is at a standstill?

HashLips is busy with another project

Is there another one active?

There’s my fork, I try to stay as compatible with the main repo as possible, and there are a few other forks as well.

For the spacing, I followed the style of the rest of the code, in which there are no spaces after ifs

Out of 32 ifs in the repo, all of them have spaces after them.

@Spyna
Copy link
Author

Spyna commented May 19, 2022

Oh sorry, you're right. Spaces, not newlines 😅. I added the commit just now for the spaces.
If your project is active and in use, feel free to create a pull request from my fork or copy the sources directly to it.

@bolshoytoster
Copy link

@Spyna

Oh sorry, you're right. Spaces, not newlines 😅

Sorry, that was probably my fault.

I’ve opened a PR for my fork, I’ll resolve the conflicts when I get home.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants