Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle large number values gracefully #3490

Open
petertonysmith94 opened this issue Dec 19, 2024 · 0 comments · May be fixed by #3491
Open

Handle large number values gracefully #3490

petertonysmith94 opened this issue Dec 19, 2024 · 0 comments · May be fixed by #3491
Assignees
@petertonysmith94
Labels
bug Issue is a bug

Comments

@petertonysmith94
Copy link
Contributor

Summary

Any number bigger than Number.MAX_SAFE_INTEGER, encoded using the BigNumber coder, could lead to malformed data. We should ensure that numbers of MAX_SAFE_INTEGER are encoded correctly and throw an error when attempting to handle a number more than this value.
@petertonysmith94 petertonysmith94 added the feat Issue is a feature label Dec 19, 2024
@petertonysmith94 petertonysmith94 self-assigned this Dec 19, 2024
@arboleya arboleya added the bug Issue is a bug label Dec 19, 2024 — with Linear
@arboleya arboleya removed the feat Issue is a feature label Dec 19, 2024
@petertonysmith94 petertonysmith94 changed the title Big number values not accepting large numbers Handle large number values gracefully Dec 19, 2024
@petertonysmith94 petertonysmith94 linked a pull request Dec 19, 2024 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petertonysmith94 petertonysmith94

Labels
bug Issue is a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: handling very large numbers gracefully FuelLabs/fuels-ts
2 participants
@arboleya @petertonysmith94