-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FreeCAD-addons] - Maintainers should NOT use pylupdate5
to update translation files
#297
Comments
What error are you getting from lupdate6? We use it exclusively on FreeCAD main, for the reasons you link to. |
From lupdate6 none, the problem is when external WB uses lupdate5 and that makes strings are not marked and thus translation is not completed, here I'm tracking WB that have this problem |
pylupdate5
to update translation filespylupdate5
to update translation files
I should note that "pylupdate6" is not the official Qt6/PySide6 executable -- we do not use it for FreeCAD main, we use Qt6's |
I just realized I explicitly said there was a problem with Today I investigated the problem and solved it, the explanation is in point 2 on shaise/FreeCAD_FastenersWB#384 Could be a regression on upstream? because Anyway, I'll test with |
In my journey translating WB I have encounter cases were some strings are not included on the
.ts
file.As Chris reported some time ago black formatted code wasn't being picked by
lupdate
, a fix was made back then and in FreeCAD code was good again but somehow it looks that this problem is still present on external WB.https://forum.freecad.org/viewtopic.php?t=65744
With this in mind when I added translation support on FreeGrid, Gears, SheetMetal, Assembly3 and Assembly 4 (WIP) I used
pylupdate6
in the scripts. I tried to do the same on Fasteners but it seems that there the code is not formatted andpylupdate5
works fine, I tried to usepylupdate6
but it gets error for some code.Reading on the issues here it seems that this is a recurring problem so maybe we can track issues related to this, the solution is to use
pylupdate6
.QT_TRANSLATE_NOOP()
confirms my suspicion [FreeCAD-addons] Reinforcement → RebarCommands (toolbar) #135Maintainers would be interested on this script that have helped me to fix this problem: #296
On my Arch Linux system
pylupdate6
is a mini script. I don't know about other systems maybe someone check that.The text was updated successfully, but these errors were encountered: