Padding problem since 1.0.7 update

[irinelenache]

Description

Some users reported they have some padding problems since the 1.0.7 update. I managed to reproduce the problem by having a cover inside a full-width group block with the Inner blocks use content width option deactivated (https://vertis.d.pr/i/TIZKWg)
How it looks with Neve FSE 1.0.6: https://vertis.d.pr/i/HT2DXZ
How it looks with Neve FSE 1.0.9: https://vertis.d.pr/i/4QWNhK

Reported here: https://wordpress.org/support/topic/padding-changes-on-v-1-0-7/ , https://wordpress.org/support/topic/padding-errors/

It should be related to the fix of this issue #101

Step-by-step reproduction instructions

1. Create a page with a group block with full-width and Inner blocks use content width option deactivated
2. Add a cover block inside the group block
3. Check how it looks with 1.0.9 compared to 1.0.6

Screenshots, screen recording, code snippet or Help Scout ticket

How it looks with Neve FSE 1.0.6: https://vertis.d.pr/i/HT2DXZ
How it looks with Neve FSE 1.0.9: https://vertis.d.pr/i/4QWNhK

Environment info

Neve FSE 1.0.9 / WordPress 6.4.3

Is the issue you are reporting a regression

Yes, this is a regression.

[JohnPixle]

Thanks for reporting @irinelenache

I also checked at our demo site at this page: https://demosites.io/neve-fse/patterns/ (first pattern is a cover inside a group)

While the cover by itself works as expected, when it is inside a group it adds the extra padding.
Also, I see that this only happens in the editor, while at the frontend it always shows correctly.

One workaround is to simply remove the padding manually from the sidebar.

I am sorry about these issues, they stem from an old regression on padding which affected the spacing setup on existing sites.
I would personally like to keep this issue in the backlog and see if @HardeepAsrani can take some time to look into it between his product experiments. We will plan for a review of the issue and follow up.

Thanks again!!

[JohnPixle]

@HardeepAsrani I do not consider it a major issue to be honest, but technically yes, you can call it a regression. However I don't think we should revert any of our padding code.

Maybe what needs to be done here is to add a css line or two that addresses the specific case when the cover block is added inside a group?

Take a look at this short video

https://www.loom.com/share/4fa5261f7d7148b188e86d66ecea92d9?sid=88078140-17de-4639-8d35-341b95bc276e

[HardeepAsrani]

Thanks John, I'll take a look at it today and address it.